search

cvg / pixel-perfect-sfm

Pixel-Perfect Structure-from-Motion with Featuremetric Refinement (ICCV 2021, Best Student Paper Award)
Apache License 2.0
1.29k stars 132 forks source link

Create release for packaging pixel-perfect-sfm in conda-forge #93

Closed Tobias-Fischer closed 1 year ago

Tobias-Fischer commented 1 year ago

Hiya, we now have pycolmap and pyceres (soon) on conda-forge. Packaging pixel-perfect-sfm should be straightforward if you create a release that I can pull in.

Phil26AT commented 1 year ago

Hi @Tobias-Fischer, thanks for your great work. This would be amazing! We are just preparing some updates on pycolmap and pixsfm, and hope to create a release early next week.

One question regarding AVX: Do we need to disable this for conda?

Tobias-Fischer commented 1 year ago

Awesome that would be great @Phil26AT.

Yes, it is safest to disable avx2 (or ideally check at rubric if it is available). Unfortunately we still don’t have a consistent way to build for multiple instruction sets and install the appropriate one in the conda ecosystem, see https://github.com/conda-forge/conda-forge.github.io/issues/1261

Tobias-Fischer commented 1 year ago

Hiya @Phil26AT - quick reminder re a release :)

Phil26AT commented 1 year ago

Hiya @Tobias-Fischer , sorry for the very late answer. I finally created a release now. AVX2 is enabled by default, but I added a check for it, and AVX2 will be automatically disabled if the test fails.

Thanks a lot for offering your help, it would be great to see pixsfm on conda-forge!

Tobias-Fischer commented 1 year ago

This has now been done: https://github.com/conda-forge/pixsfm-feedstock Installation is easy: mamba install pixsfm - works on linux and osx.

I'll soon tweet / advertise this new means of installation :)