search

cvg / pixloc

Back to the Feature: Learning Robust Camera Localization from Pixels to Pose (CVPR 2021)
Apache License 2.0
735 stars 92 forks source link

Error in the demo notebook: add_prefixes() missing 1 required positional argument: 'eval_dir' #8

Closed bperel closed 2 years ago

bperel commented 2 years ago

When trying to run the demo notebook, the following error appears: 

TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_37/2660258349.py in <module>
      8 
      9 print(f'default paths:\n{pformat(default_paths.asdict())}')
---> 10 paths = default_paths.add_prefixes(DATA_PATH/dataset, LOC_PATH/dataset)
     11 
     12 conf = default_confs['from_retrieval']

TypeError: add_prefixes() missing 1 required positional argument: 'eval_dir'

Indeed, the call to add_prefixes seems to be missing a parameter: 

paths = default_paths.add_prefixes(DATA_PATH/dataset, LOC_PATH/dataset)
sarlinpe commented 2 years ago

Thanks for bringing this up, I just fixed it with https://github.com/cvg/pixloc/commit/3cd09d559ca46a7ab161793adde838974011b265. Let me know if anything else shows up.

bperel commented 2 years ago

Thanks! With your fix the notebook run goes until the end :-)