cvghivebrain / s1disasm

Sonic the Hedgehog (Mega Drive) Hivebrain 2022 disassembly
45 stars 8 forks source link

Z80 "AND" and "SUB" instructions use wrong macro parameter for "getzreg" #28

Closed DevsArchive closed 2 years ago

DevsArchive commented 2 years ago

Also, ASM68K does not play nicely with spaces in if statements. Was using this to program some Z80 stuff and I've had ld de,(284h-508h)*2 assemble as ld de,((284h-508h)*2) because it wasn't even applying the 2nd strcmp. It might be worth looking into a better way to detect parenthesis, because I can see stuff like ld a,(num1)*(num2) becoming an issue.

Brainulator9 commented 2 years ago

Also, ASM68K does not play nicely with spaces in if statements. Was using this to program some Z80 stuff and I've had ld de,(284h-508h)*2 assemble as ld de,((284h-508h)*2) because it wasn't even applying the 2nd strcmp. It might be worth looking into a better way to detect parenthesis, because I can see stuff like ld a,(num1)*(num2) becoming an issue.

Does this include with the WS assembler option on?

DevsArchive commented 2 years ago

...it DOES help to have that on lol.