fixed forward and backward buttons

cvhciKIT / sloth

Sloth is a tool for labeling image and video data for computer vision research.

Other

611 stars 198 forks source link

fixed forward and backward buttons #125

Closed NeuralNetwork closed 7 years ago

nilsonholger commented 7 years ago

Hey @NeuralNetwork, thx a lot for taking the time to create this pull request. Sorry it took me so long to reply, it's been quite busy.

I'm really inclined to accept this pull request (it's small, it passes all checks, it seems to fix a problem), but could you please state with a few words what kind of problem this fixes exactly? Your description "fixed forward and backward buttons" doesn't really tell the full story, I suppose?!

NeuralNetwork commented 7 years ago

The changes to model.py make the behavior of the forward and backward buttons consistent. The backward button does not wrap around anymore.

Regarding labeltool.py: The signal clicked(bool checked=false) supplies a bool to a connected slot. That bool was previously consumed by gotoPrevious(self, step=1) or gotoNext(self, step=1). false is cast to 0 which is not what we want here.

nilsonholger commented 7 years ago

OK, thx for the clarifications, merged.