cviebrock / eloquent-taggable

Easily add the ability to tag your Eloquent models in Laravel.
MIT License
559 stars 72 forks source link

Laravel 10.x Compatibility #137

Closed laravel-shift closed 1 year ago

laravel-shift commented 1 year ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 1 year ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift commented 1 year ago

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift commented 1 year ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/eloquent-taggable.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "cviebrock/eloquent-taggable": "dev-l10-compatibility",
    }
}

Finally, run: composer update

it-can commented 1 year ago

@cviebrock can you merge and tag pleaase?

cviebrock commented 1 year ago

@it-can I would ... except the PR is failing. I have a laravel-10 branch in progress, so expect a new version shortly.

it-can commented 1 year ago

@cviebrock orchestra/database is the problem from what i can see, it has some references to illuminate packges that are locked at ^9.0

cviebrock commented 1 year ago

Yeah, I removed it as it's not required anymore. The new 10.0.0 version should work ... if you have trouble, please open a new issue.

it-can commented 1 year ago

Thanks!