search

cviebrock / eloquent-taggable

Easily add the ability to tag your Eloquent models in Laravel.
MIT License
559 stars 72 forks source link

Standardization - Table Primary Key Naming #22

Closed superdummy closed 8 years ago

superdummy commented 9 years ago

Hello,

your library is cool (as written in another github issue), I use three of them. Thanks for developing it.

Just a thought. Our world would be so much better if people agree more in things (often even disagreement leading to severe wars...). One small subset of "more agreeing" is standardization and yes the world would save billions of hours of work (that could then be used for other usefull stuff and making the world a better place), if stuff would be more standardized.

Long story short: I personally would say that defining the primary Key of the Tag table as $table->increments('tag_id'); is not standard at all. Standard would be: $table->increments('id'); This leads to various disadvantages like not remembering it and also to not be able to use highly standardized logic like "auto referenceing" tables based on convetions...

Thanks!

cviebrock commented 8 years ago

Yeah, I get it. There are advantages, however to using something like tag_id over just id, especially when joining many tables that all have an id column.

In any case, hopefully the package provides all the methods and services so the details are abstracted away.