search

cviebrock / sequel-pro-laravel-export

A Sequel Pro / Sequel Ace bundle to generate Laravel migration files from existing tables.
MIT License
921 stars 55 forks source link

Including charset and collation for tables and columns #31

Closed khadiwaa closed 4 years ago

khadiwaa commented 4 years ago

First of all, thank you for your project! It's saving me a lot of time in being able to bring migrations into a new project for an old database.

With this old database, many of the columns specify a charset or collation that differs from that of the table or schema. Likewise many of the tables have varying charsets/collations. I figured I'm not the only one to run into this situation.

As well, I made some small adjustments to the shell script, wrapping filenames in quotes and fixing a small bug for a conditional test. I also reduced some of the extra new lines in the resulting migration. And I made a minor bump in the version.

Hopefully this is something that can be helpful to others! Any feedback is appreciated.

cviebrock commented 4 years ago

Sorry this took so long to merge!

khadiwaa commented 4 years ago

Awesome! Hopefully that stuff will be helpful for others, and thank you for creating this bundle!