feat(ui): add ability to change UI of template selection

[AgatZan]

• chore: added typing
• fix(wildcard): bugfix wildcard.parse. When finding a wildcard at lookup, it doesn't check if it function or string.
• fix(util): probably bugfix. The default value for the inserttable pattern is nil. If gettemplates encounters nil, it will not process it.
• feat(ui): Adding probability to change the default UI when selecting a template process. ( async or not)

[cvigilv]

Awesome PR! Just a couple of questions:

1. Why did you revert the CI implementation?
2. Could you provide an example of a custom selector in the README? or even here, so I can test it works properly.
3. With the provided changes, I'm unable to make the plugin work. Could you provide your configuration to test it?

Thanks for the awesome work, I was aiming to implementing stuff like this in a near future whenever I was a little more free from work.

[AgatZan]

Awesome PR! Just a couple of questions:

1. Why did you revert the CI implementation?
2. Could you provide an example of a custom selector in the README? or even here, so I can test it works properly.
3. With the provided changes, I'm unable to make the plugin work. Could you provide your configuration to test it?

Thanks for the awesome work, I was aiming to implementing stuff like this in a near future whenever I was a little more free from work.

1. Because I was trying to figure it out during the work period, but since it fell with every commit, I decided that I still need to work on it.

In general, in order to start covering the repository with tests

2. I added selector to esqueleto/selector/builtin

function(templatenames)
    -- Sync call ui.select
    -- See: https://github.com/mfussenegger/nvim-dap/blob/66d33b7585b42b7eac20559f1551524287ded353/lua/dap/ui.lua#L55
    local co = coroutine.running()
    local choicer = function(choice)
        if not choice then
            vim.notify(
                "[esqueleto] No template selected, leaving buffer empty",
                vim.log.levels.INFO
            )
        end
        coroutine.resume(co, choice)
    end
    -- I don't know reason to use that
    -- choicer = vim.schedule_wrap(choicer)
    vim.ui.select(templatenames, { prompt = "Select skeleton to use:" }, choicer)
    return coroutine.yield()
end

I took the very idea of implementing this from here

3. I got a little carried away with my study of the codebase through adding types and missed this point, so most likely there will be bugs. I apologize m( )m

nevertheless, after checking, I have it open on simple files

my config

[cvigilv]

1. Perfect, I will do some work now dedicated to CI/CD so I can release a new version.

2. I noticed it, just thought you may have implemented something custom on your config (like a Telescope selector or something like that). I'll give it a go to implement new selectors locally, but for now this works as intended.

Regarding point 3. I made a mistake on my side, that's why it didn't work. It works as intended so, don't worry.

Overall the PR is great, just some stylistic differences that can be revised. Will merge on the weekend after going through everything in the case I need some changes. Thanks!

[cvigilv]

Haven't merged this since its not working on my local version. Will try to see how I can incorporate this in the coming version. For now I will let it as is and get back to it whenever I finish the other things I'm developing for the plugin.

[cvigilv]

Could you provide a screen recording of this working? havent been able to make it work in my local version

[AgatZan]

Could you provide a screen recording of this working? havent been able to make it work in my local version

plugin/esqueleto.lua

return {
    "AgatZan/esqueleto.nvim",
    ---@type Esqulato.config
    opts = {
        patterns = { "python" },
    },
}

It`s test builtin selector

[AgatZan]

Also work with esqueleto.selectors.telescope but if you use lazy this may be obvious, but at opts selector=require("esqueleto.selectors.telescope") throw error, so configurate at config = function()

[cvigilv]

It indeeds works, dont know why it would not work on my computer. What version of Neovim are you using? I generally work in nightly for plugin dev.

[AgatZan]

NVIM v0.10.1 Build type: Release LuaJIT 2.1.1713484068

[AgatZan]

I test it with minimal-minimal setup.

DEV_DIR = "~/nvim-plug/esqueleto.nvim"
vim.opt.rtp:prepend(DEV_DIR)
require("esqueleto").setup({patterns = {"python"}}

And only 1 that i found, that i should decorate if selectors/builtin.lua choicer

[cvigilv]

I didnt get what you refer to. I prefer you test things with the lazy-based minimal example since the vast majority of user use lazy for pkg management.

[AgatZan]

I think it doesn't really matter, but i test and it works

[cvigilv]

Are you cleaning the plugins whenever you launch neovim? I'm using CLI neovim and use the NVIM_APPIMAGE environmental variable to ensure no other plugins are being loaded. I don't know if there is an equivalent in Neovide.

[AgatZan]

I removed all cached plugins and used a minimal setup and use cli nvim. I had no problems.

[cvigilv]

Lost for words here. Will have to deep dive into telescope to see what is the problem. Thanks for your help