search

cvisionai / tator-py

Python client for Tator
https://www.tator.io/docs/references/tator-py
MIT License
4 stars 3 forks source link

Transcode module's --cleanup function deletes input media #60

Closed sbatchelder closed 1 year ago

sbatchelder commented 1 year ago

When using 'python -m tarot.transcode VIDEO.MP4 --work_dir TRANSCODE_DIR --cleanup' I expected only the files under TRANSCIDE_DIR to be deleted. Instead, VIDEO.MP4 also gets deleted.

This caused me to lose the full resolution videos for my project.

If this is not the intended behavior, then this is a big and should be fixed. If this IS the intended behavior, then the '--help' text for the '--cleanup' flag should be updated. The current help text, "Deletes working files after each file is transcoded and uploaded" doesn't make this clear

jrtcppv commented 1 year ago

That is definitely an oversight and we will prioritize this for a fix in an upcoming release.

jrtcppv commented 1 year ago

I am putting the fix for this issue into the release candidate branch for Tator 0.2.23, with official release scheduled for early next week. In the meantime, I just updated the wheel on pypi (version 0.10.29) with this fix. From 0.2.23 on the pypi package version will match the current stable tator release version. Really sorry about this issue.

sbatchelder commented 1 year ago

Hi Jon,

It was mostly surprising/a little scary. I don't think any data was lost forever. We either have backups or the still images the videos were derived from saved elsewhere.

Glad you got a fix in quick.

-Sidney

From: Jonathan Takahashi @.> Sent: Wednesday, February 22, 2023 7:14 PM To: cvisionai/tator-py @.> Cc: Sidney Batchelder (she/her) @.>; Author @.> Subject: [EXTERNAL] Re: [cvisionai/tator-py] Transcode module's --cleanup function deletes input media (Issue #60)

This email originated outside of WHOI. Please use caution if clicking on links or opening attachments.

I am putting the fix for this issue into the release candidate branch for Tator 0.2.23, with official release scheduled for early next week. In the meantime, I just updated the wheel on pypi (version 0.10.29) with this fix. From 0.2.23 on the pypi package version will match the current stable tator release version. Really sorry about this issue.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcvisionai%2Ftator-py%2Fissues%2F60%23issuecomment-1441032964&data=05%7C01%7Csbatchelder%40whoi.edu%7C6afc90fc0b7847f7575908db1532fd5c%7Cd44c5cc6d18c46cc8abd4fdf5b6e5944%7C0%7C0%7C638127080989919193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ENJt%2FF7Y8%2FUVBsumQi5qW3%2FOXVLki6zn%2FHEkUq8FBgE%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKRJC7PGPI6XWVBJN5SBMGDWY2TX5ANCNFSM6AAAAAAVEYHAOM&data=05%7C01%7Csbatchelder%40whoi.edu%7C6afc90fc0b7847f7575908db1532fd5c%7Cd44c5cc6d18c46cc8abd4fdf5b6e5944%7C0%7C0%7C638127080989919193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9j64LlByrBXUxaoqQYjIJaAjL3KAlvsgvxp9ouiHLJo%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>