search

cvitolo / fuse

fuse: an R package implementing the Framework for Understanding Structural Errors
https://cvitolo.github.io/fuse/
12 stars 1 forks source link

fusesma.sim/fuserouting.sim/fuse #11

Closed maelle closed 7 years ago

maelle commented 7 years ago

This issue is part of this JOSS review

Why not have the random seed as argument of fusesma.sim and fuserouting.sim and fuse (or of fuseonly since it calls both other functions), with a default value, to make results reproducible even if the user forgets about the seed?

cvitolo commented 7 years ago

The functions fusesma.sim, fuserouting.sim and fuse do not generate internally the parameter sets but uses pre-defined ones because there are various ways of sampling the parameter ranges. The function generateParameters() only uses one of them (latin hypercube). For this reason, the parameter sets should be generated prior to using fuse and not within it.

maelle commented 7 years ago

But you still use a random seed before calling them, right? Not important though :-)

cvitolo commented 7 years ago

Sorry, I should have clarified that I only set the seed before running generateParameters to have always the same parameters in my examples.