cvitolo / fuse

fuse: an R package implementing the Framework for Understanding Structural Errors
https://cvitolo.github.io/fuse/
12 stars 1 forks source link

Name and format of DATA #4

Closed maelle closed 7 years ago

maelle commented 7 years ago

This issue is part of this JOSS review

The most important remark of this issue: the doc states DATA is a data.frame but it's actually a zoo object, could you update the doc or the object itself?

These are details and only suggestions:

maelle commented 7 years ago

By the way since it is a zoo object, in the doc you could add "plot(DATA)" in Examples, it's quite nice one gets to see the time series so easily. :-)

cvitolo commented 7 years ago

I have changed the name DATA to fuse_hydrological_timeseries and updated the documentation (format is now zoo) and added plot(fuse_hydrological_timeseries) to the examples in the doc.

I cannot changed the name of the name of the columns because this is a convention in modelling frameworks (e.g. Fortran fuse and hydromad).

maelle commented 7 years ago

Ok, cool!