search

cvlab-ai / polish_banknotes

Czytnik Polskich Banknotów is a mobile app for detecting polish banknotes using neural networks
GNU General Public License v3.0
8 stars 2 forks source link

Update and reorganize dependencies #123

Open PatrykMis opened 10 months ago

PatrykMis commented 10 months ago

As a visually impaired user, I want to express my gratitude for the excellent and helpful app! Instead of sending a traditional "thank you" email, I've taken the initiative to contribute to the Android port. While this isn't a comprehensive overhaul, I've made initial updates.

I've ensured that all dependencies are up-to-date, along with making minor code adjustments to align with recent updates. If you welcome pull requests, I am open to performing further code refactoring, including modernizing deprecated code and making improvements for TalkBack and potentially other screen readers.

All additional explanations are inside commits descriptions.

jankejc commented 7 months ago

Thank you very much for your contribution. It is very meaningful to not only congratulate for the app, but literally give something from yourself.

jankejc commented 7 months ago

Unfortunetely I see that checks fails and it is something with Gradle version and the navigation-safe-args (if I'm not mistaken). If you are able to correct that it would be great. Until then I don't want to risk the stability of the app.

PatrykMis commented 7 months ago

Everything should work as expected now. I made further updates and had to bump minSdk to 26 because of latest TensorFlow. The oldest supported Android version is at API level 30, so keeping minSdk as low as 24 is a nonsense. See also: https://gs.statcounter.com/android-version-market-share

jankejc commented 7 months ago

Alright, thank you for your fast response. I'm trying to run the app with your changes on branch chore/dependency-updates, but it throws me a problem with Gradle version (max. 8.1.0, but in app/build.gradle there is 8.3.0). Moreover, in this Pull Request there is different stuff in this file. I'm not an expert, but have you merged chore/dependency-updates to your main? I would like to test the app physically, and I am not sure if it is possible without this... I think that in this Pull Request is all the app needs (like it was merged), and I assume it would be just fine, but I don't want to rely on GitHub checks only.

PatrykMis commented 6 months ago

You need Android Studio Jellyfish or later to successfully build Android project after my update. See the Android Studio compatibility information with AGP (Android Gradle Plugin).