search

cvmfs-contrib / config-repo

Master source for CVMFS configuration repository for major organizations
4 stars 20 forks source link

Adding new cache - osg-stash-sfu-computecanada-ca.nationalresearchplatform.org - egi branch #157

Closed biozit closed 1 year ago

biozit commented 1 year ago

We have a new Canada cache: osg-stash-sfu-computecanada-ca.nationalresearchplatform.org

DrDaveD commented 1 year ago

Oh and this should instead be added to the next line where it says "stashcache servers not configured by OSG".

biozit commented 1 year ago

Oh and this should instead be added to the next line where it says "stashcache servers not configured by OSG".

why?

DrDaveD commented 1 year ago

Oh and this should instead be added to the next line where it says "stashcache servers not configured by OSG".

why?

Oh I guess the comment is a little misleading. It means that it's not configured in the osg branch.

biozit commented 1 year ago

done

biozit commented 1 year ago

done

biozit commented 1 year ago

done

jose-caballero commented 1 year ago

https://cbea.ms/git-commit/

biozit commented 1 year ago

No problem, please. Could you check if it is ok?

--Fábio Andrijauskas

On Thu, Feb 16, 2023 at 10:03 AM Jose Caballero @.***> wrote:

https://cbea.ms/git-commit/

— Reply to this email directly, view it on GitHub https://github.com/cvmfs-contrib/config-repo/pull/157#issuecomment-1433498703, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEEH74V47ZXZ33EYMCXI2LWXZTWXANCNFSM6AAAAAAU5K7EEQ . You are receiving this because you authored the thread.Message ID: @.***>

biozit commented 1 year ago

np, done.

--Fábio Andrijauskas

On Thu, Feb 16, 2023 at 10:27 AM DrDaveD @.***> wrote:

@.**** requested changes on this pull request.

Unfortunately it is still not ok, because now the first line has Adding new cache - osg branch which is not only incorrect since it is the egi branch, it is too generic. The second line is good; just use the second line as the first line. You don't need to mention the branch name in the commit, because that's obvious from where it is. It's good to have the branch name in the PR title, as you did.

— Reply to this email directly, view it on GitHub https://github.com/cvmfs-contrib/config-repo/pull/157#pullrequestreview-1302050805, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEEH75EBXA4U5IZP4IQCWDWXZWRPANCNFSM6AAAAAAU5K7EEQ . You are receiving this because you authored the thread.Message ID: @.***>

DrDaveD commented 1 year ago

Ok for @jose-caballero to merge & deploy.

@biozit Also please cherry-pick this to the master branch.