search

cvmfs-contrib / cvmfs-manage-replicas

Automated cvmfs stratum 1 replica addition and deletion
Other
0 stars 2 forks source link

add_repository doesn't manage https source urls #9

Closed sgaravat closed 1 month ago

sgaravat commented 1 month ago

add_repository doesn't manage https source URL (this can be needed e.g. for a S3 backend)

This piece of code:

case "$2" in
    http://*) REPOURL="$2/cvmfs/$REPONAME";;
    continue) CREATEREPO=false;;
    *)  usage ;;
esac

should be replaced with something like (I am not able to find the right glob expression):

case "$2" in
    http://*) REPOURL="$2/cvmfs/$REPONAME";;
    https://*) REPOURL="$2/cvmfs/$REPONAME";;
    continue) CREATEREPO=false;;
    *)  usage ;;
esac
DrDaveD commented 1 month ago

How about just changing http://* to http*://*. Does that work for you?

sgaravat commented 1 month ago

Yes: http:// works as well Thanks, Massimo

DrDaveD commented 1 month ago

So it will be in the next release. Do you need me to make a new release or is it good enough for you to work with a hacked copy until then?

sgaravat commented 1 month ago

Thank you ! Yes: I can live with the hacked copy waiting for the new release