search

cvn / angular-shims-placeholder

Angular directive to emulate the placeholder attribute on text and password input fields for old browsers, such as IE9, IE8, and IE7. Also works on textareas and html5 input types.
MIT License
63 stars 26 forks source link

IE8 Password field fix #3

Closed cvn closed 10 years ago

cvn commented 10 years ago

Hello, This PR reintroduces support for password fields in IE8.

@rudasn originally added support in PR https://github.com/jrief/angular-shims-placeholder/commit/c46e13726dd8a0b7b3a55ade822b662207479e78

Unfortunately, his PR merged the code into /dist/angular-shims.placeholder.js instead of /lib/angular-placeholder.js, so it got overwritten when rebuilt dist files were added in PR https://github.com/jrief/angular-shims-placeholder/commit/f05c0d8b805a0927a861e27777a1f628b41cff79

The original code also didn't fully work in IE8, and was dependent on jQuery. I resolved the functionality issues and reimplemented the jQuery methods in pure JS.

I also updated the karma tests related to the password field, and incremented the project version number.

I will be submitting an additional PR incoming that resolves some environment issues I ran into while testing.

cvn commented 10 years ago

Hi @jrief, Can you look into merging this (and PR #4)?