search

cvn / angular-shims-placeholder

Angular directive to emulate the placeholder attribute on text and password input fields for old browsers, such as IE9, IE8, and IE7. Also works on textareas and html5 input types.
MIT License
63 stars 26 forks source link

Improved Tooling #4

Closed cvn closed 10 years ago

cvn commented 10 years ago

PR https://github.com/jrief/angular-shims-placeholder/pull/3 should be merged before looking into this one, since it will make the diff more readable. This PR resolves the travis-ci build failure from the other PR.

This cleans up some of the environment configuration and adds bower to manage testing dependencies.

angular and angular-mocks will now both be installed by bower when running npm install.

jrief commented 10 years ago

Thanks @cvn for this huge patch! Some notes from my site, I just merged it on my local host and ran the unit tests. Everything works fine, but I have annotations about these files:

cvn commented 10 years ago

@jrief I removed the wget from .travis.yml. The bower install is automatically triggered as an npm postinstall, specified in the package.json file. This is a little "magical", but I like it.

.editorconfig is a file that makes IDEs respect the tab style of the project, so that things stay consistent in your source, instead of having mixed tab characters and spaces, depending on who edits it. There's some other settings too, but they're minor. editorconfig is implemented as a plugin that supports most major IDEs. It doesn't help if someone doesn't have the plugin installed, but for people who want to be courteous, it makes it easier on them so they don't have to manually change their tab settings when they're working in your repo.