cvogt / cbt

CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala
Other
488 stars 60 forks source link

REPL for Scala 2.11.6 and below crippled #497

Open Jasper-M opened 7 years ago

Jasper-M commented 7 years ago

When starting a REPL for a scala version below 2.11.7 I get

Failed to created JLineReader: java.lang.NoClassDefFoundError: jline/console/ConsoleReader
Falling back to SimpleReader.
cvogt commented 7 years ago

Hi, I can't reproduce this. Can you please re-open with instructions how to reproduce? Thx

Jasper-M commented 7 years ago

@cvogt I don't think I can reopen, but this reproduces it on my end:

On Ubuntu 14.04 LTS, with $PATH already configured:

$ git clone https://github.com/cvogt/cbt.git
$ cbt

And then either

$ cbt direct tools scala 2.11.6

or

$ mkdir cbttest
$ cd cbttest
$ cbt tools createBuild
$ cbt tools createMain
$ sed -i '4ioverride def defaultScalaVersion = "2.11.6"' build/build.scala
$ cbt direct repl

For every version below 2.11.7 I get Falling back to SimpleReader. which means that tab completion, scrolling through history etc doesn't work. Not a huge deal, but there is a chance you still have to support 2.10.6 in some projects.

Would be strange if this issue is only on my end. sbt "++2.11.6 consoleQuick" works fine by the way.

cvogt commented 7 years ago

weird. I tried this exact sequence on circleci, which runs ubuntu and it works fine there.

Try deleting cbt's caches.

killall -KILL java # kill background process
cd <cbt-home>
rm -rf cache # maven and git repo cache
find . | grep target\$ | xargs rm -rf # remove target directories
Jasper-M commented 7 years ago

I deleted cbt and cloned it again when I wrote the reproduction instructions. I might have forgotten to kill nailgun though. But starting the REPL uses direct so I'm not sure if that made a difference. Will retry when I have some time.


From: Jan Christopher Vogt notifications@github.com Sent: Wednesday, April 26, 2017 8:48:15 PM To: cvogt/cbt Cc: Jasper Moeys; Author Subject: Re: [cvogt/cbt] REPL for Scala 2.11.6 and below crippled (#497)

weird. I tried this exact sequence on circleci, which runs ubuntu and it works fine there.

Try deleting cbt's caches.

killall -KILL java # kill background process cd rm -rf cache # maven and git repo cache find . | grep target\$ | xargs rm -rf # remove target directories

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cvogt/cbt/issues/497#issuecomment-297505805, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADiVwXFIxPUCTOtv7HRDZWvw4gfYcZeRks5rz5FvgaJpZM4NEdyq.

cvogt commented 7 years ago

If that's not it, I don't know.

I doubt killing nailgun would have made a difference. Just put it in there to be safe.

Jasper-M commented 7 years ago
$ cbt direct tools scala 2.10.6
Failed to created JLineReader: java.lang.NoClassDefFoundError: scala/tools/jline/console/ConsoleReader
Falling back to SimpleReader.
Welcome to Scala version 2.10.6 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_131).
Type in expressions to have them evaluated.
Type :help for more information.

scala> 

Nope :/

cvogt commented 7 years ago

Ok, I could reproduce this now :). Will take a look.