Rudimentary Macroparadise plugin

cvogt / cbt

CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala

Other

488 stars 60 forks source link

Closed megri closed 7 years ago

cvogt commented 7 years ago

love it. Ideal would be a follow up commit or PR, that adds your experiment to the examples/ folder

megri commented 7 years ago

Is it ok in its raw adulterated form as shown on megri/cbt-test?

cvogt commented 7 years ago

yes. ideally add a line here to check it produces the right output: https://github.com/cvogt/cbt/blob/master/test/test.scala#L424

and if you want to turn it into a single build file multi-project build, that might be nice :)

cvogt commented 7 years ago

Gave it another look. How is this different from the existing Scala paradise plugin?

cvogt commented 7 years ago

Except for better implementation and version number?

cvogt commented 7 years ago

Should it maybe replace it?

megri commented 7 years ago

I believe Scalaparadise.scala enables scala.reflection-based (old-style) macros for Scala 2.10-projects and macro annotations for 2.11+.

Macroparadise.scala on the other hand enables scala.meta-style macros. I believe they are currently limited to macro annotations only.

megri commented 7 years ago

Updated the PR to use a single build.scala. Please review and comment on whether or not it looks sane :)

megri commented 7 years ago

Rebased PR on upstream

megri commented 7 years ago

Added the renaming as a separate commit. Can squash if desired

cvogt commented 7 years ago

Awesome. Merging