cvogt / cbt

CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala
Other
488 stars 60 forks source link

Added a cbt plugin for the kind-projector compiler plugin #519

Closed etorreborre closed 7 years ago

etorreborre commented 7 years ago

@cvogt is this all there is to do?

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

cvogt commented 7 years ago

@etorreborre yeah, happy to merge as is. even better would with with a small example project in /examples and triggering the example from the tests, similar to https://github.com/cvogt/cbt/pull/515

cvogt commented 7 years ago

fixed the compile error. I love how github now let's you push to branches of PRs opened against your repo

etorreborre commented 7 years ago

I tried to run the tests and I got:

~/projects/scala/cbt/test on kind-projector-plugin
± cbt run
Skipping slow tests
java.lang.Exception: Linting error in ./cbt bash launcher script:

    at cbt.test.Main$.cbtMain(test.scala:39)
    at cbt.test.Main.cbtMain(test.scala)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at cbt.reflect.Module$$anonfun$typeStaticMethod$1.apply(reflect.scala:170)
    at cbt.reflect.StaticMethod.apply(StaticMethod.scala:4)
    at cbt_build.cbt.test.Build.run(build.scala:7)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
cvogt commented 7 years ago

@etorreborre master is giving a better error message since yesterday or so. Basically you need to install shellcheck from brew or apt, etc

etorreborre commented 7 years ago

Ok, now I get

In /Users/etorreborre/projects/scala/cbt/cbt line 144:
JAVA_OPTS_CBT=($DEBUG -Xmx1536m -Xss10M -XX:MaxJavaStackTraceDepth=-1 -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Xverify:none)
                                        ^-- SC2191: The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it.
                                                                                             ^-- SC2191: The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it.
cvogt commented 7 years ago

@etorreborre that's fixed in master

etorreborre commented 7 years ago

I don't know what I'm doing wrong but I still get the same issue. Can you please try on your side on my PR?

cvogt commented 7 years ago

Ok, I just did. Seems like a new linting rule introduced by the latest shellcheck 0.4.6. Merging master into this PR fixed it.

cvogt commented 7 years ago

we should be good now :)

etorreborre commented 7 years ago

All green!

cvogt commented 7 years ago

@etorreborre nice, thx for the example :)!

cvogt commented 7 years ago

merged!