search

cvogt / cbt

CBT - fun, fast, intuitive, compositional, statically checked builds written in Scala
Other
488 stars 60 forks source link

Create a ScalaXB Plugin #556

Open Jacoby6000 opened 7 years ago

Jacoby6000 commented 7 years ago

Most of this seems to work, aside from a class loader issue that's preventing me from testing it.

Any suggestions for improvements welcome while I try to sort it out!

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

cvogt commented 7 years ago

@Jacoby6000 in order to sign the CLA you need to add the email address used in your commits to your github account.

cvogt commented 7 years ago

will look into the crash now :)

cvogt commented 7 years ago

Getting closer. This seems be be caused by cbt itself using an older Scala version (2.11.8) than one of the dependencies of the plugin (2.11.11). We could temporarily fix this problem but upgrading cbt's scala version but it would also apply again whenever a new Scala version comes out. Will have to think of a solution for this. Nice find in any case. This would have popped up soon anyways.

cvogt commented 7 years ago

btw. the way I found out is by printing the classloader in the top line of cbt in the StackTrace of the crash. Lib.scala:70

cvogt commented 7 years ago

While I am still working on a more permanent fix, if you rebase your PR on this one: https://github.com/cvogt/cbt/pull/560 you should be unblocked. Upgrading scala to 2.11.11 solved the problem for now. Note that there is still a crash, but it looks like a problem in your plugin this time.

cvogt commented 7 years ago

(#560 currently fails the build, but don't worry about that. It looks like it only affect cross-cbt-version integration, which shouldn't block you here and I'll look into as well)

Jacoby6000 commented 7 years ago

Awesome, thanks for looking in to this! I'll poke at it in a bit.

Jacoby6000 commented 7 years ago

I'll work on the tests, since we've addressed that classloader issue