cvpaperchallenge / Crux

Crux is a suite of LLM-empowered summarization and retrieval services for academic activity. Crux is developed by XCCV group of cvpaper.challenge.
MIT License
15 stars 2 forks source link

#14/chore/implement ci #21

Closed YoshikiKubotani closed 1 year ago

YoshikiKubotani commented 1 year ago

Issue URL

14

Change overview

How to test

  1. Fork this project
  2. Raise the pull request from #14/chore/implement-ci to develop on the forked repository
  3. Merge the pull request
  4. Make a small change on the develop branch and commit it to the new branch
  5. Raise the pull request from that new branch to develop
  6. Open the Actions tab and check the CI works without any errors

Note for reviewers

I implemented the very basic cache features, but some problem still remains.

  1. When the trigger is pull_request, a cache is attached to refs/pull/{pull_request_number}/merge, so the cache is valid for operations only on that pull request, not on the base branch or any other pull requests targeting that base branch [link]
  2. Past caches are not deleted (the CI process triggered by the updates to the same pull request will successfully use the past cache, but a new cache will be created and do not overwrite the old one)
    • Running log for the 1st time image
    • Running log for the 2nd time (successfully receive cache) image
    • Duplicated cache image