Closed YoshikiKubotani closed 1 year ago
@YoshikiKubotani It looks like CI still raise error due to code format? Can you fix this?
@gatheluck
That's because I added the basic template of the main logic under backend/src/core_logic.py
, while it's not called.
and flake8 raises errors when functions and variables are defined but not used.
I think it's okay to ignore that since it would help us when we try to fully implement the logic in the future.
I've checked the type check and code format test were successfully passed.
Issue URL
15 #16
Change overview
How to test
Endpoint Unit Test
Run the following command.
Architecture Check
Check the features separation is reasonable and follows S.O.L.I.D Principles
Type Check
Run the following command.
Note for reviewers
Response
class, the dynamic type checking by the pydantic model specified in response_model will not work. So I fixed theResponse
class indefault_response_class
and returned data as dictionary type.backend/src
. Please work on that task in #19Questions
routers.py
, but is that correct?controller.py
. When the logic is static, like Owan, the test can be configured to pass even after the logic is implemented. However, how should we configure the test for our case, where the solution changes dynamically (as the summary has a large variance)?multipart/form-data
andapplication/json
consecutively as separate POST processes instead of simultaneously?