search

cvqluu / simple_diarizer

Simplified diarization pipeline using some pretrained models - audio file to diarized segments in a few lines of code
GNU General Public License v3.0
141 stars 27 forks source link

Undeclared IPython dependency #12

Open SageRalph opened 1 year ago

SageRalph commented 1 year ago

The current package (0.0.12 on PyPI) cannot run without IPython, but this is missing from requirements.txt

Steps to reproduce (outside of a Jupyter notebook):

pip install simple-diarizer

# index.py
from simple_diarizer.diarizer import Diarizer

Output:

File "[redacted]\index.py", line 1, in <module>
    from simple_diarizer.diarizer import Diarizer
File "[redacted]\lib\site-packages\simple_diarizer\diarizer.py", line 13, in <module>
    from .utils import check_wav_16khz_mono, convert_wavfile
File "[redacted]\lib\site-packages\simple_diarizer\utils.py", line 8, in <module>
    from IPython.display import Audio, display
ModuleNotFoundError: No module named 'IPython'
cvqluu commented 1 year ago

This should have been fixed in 500a80b5c47f34a9edf70eaf019f059fda8e2d14 , released in v0.0.13, let me know if this still happens