search

cvra / can-bootloader

The bootloader used to flash our CAN-connected boards
BSD 2-Clause "Simplified" License
144 stars 51 forks source link

Add a tool to change the node ID #49

Closed antoinealb closed 9 years ago

antoinealb commented 9 years ago

I thought it was pretty dangerous to use the config write tool to change node IDs, since it allowed multicast write, which can lead to ID collision. Plus the tool needed to be run twice, since it would not execute the flash write command since it changed its ID in the meantime.

My suggested solution is to extract this functionality into its own utility, mark it as explicitly dangerous, and only allow it to change one node ID at the time.

Stapelzeiger commented 9 years ago

A nice functionality would be to ping the ID first to see if it is already in use.

antoinealb commented 9 years ago

It doesn't provide a lot of added safety but I can do it once I implement ping (got some problems to make it work).

Le samedi 14 février 2015, Patrick Spieler notifications@github.com a écrit :

A nice functionality would be to ping the ID first to see if it is already in use.

— Reply to this email directly or view it on GitHub https://github.com/cvra/can-bootloader/pull/49#issuecomment-74372648.