search

cvra / robot-software

CVRA monorepo - All software running on our bots lives here
MIT License
43 stars 21 forks source link

[WIP] Wheel Encoder Firmware #272

Closed msplr closed 2 years ago

msplr commented 4 years ago

Have you thought about organizing the code in a similar way to what we did with the proximity beacon ?

There is very little code shared between wheel-encoder and motor-control firmwares. If we really plan to go forward with a dedicated board I would like to keep it separate.

Now that the master firmware modifications are added in this branch I wonder if it is meant to be merged into master?

antoinealb commented 4 years ago

Now that the master firmware modifications are added in this branch I wonder if it is meant to be merged into master?

We can always remove the changes to master before merging, they live in their own little commits. I just did not want to have them only on my PC :)

msplr commented 4 years ago

Ok for me. I believe it is not much effort to replicate the functionality on a motor-control-board. So once this is ready I will revert and merge.