cvs-health / testaro

A thousand web accessibility tests performed by 11 tools
MIT License
29 stars 10 forks source link

linkUl classification #7

Closed jrpool closed 2 years ago

jrpool commented 2 years ago

A commentator finds that the linkUl test classifies some block links as inline links on webaim.org.

jrpool commented 2 years ago

Analyzed this case and found one non-underlined link in a text node consisting of <br>-delimited substrings, whose other substrings are not links. Judged that case one that requires underlining. Also reviewed linksByType proc and decided that it was unreasonably complex, nonsemantic, and permissive. Revised it to perform a simple classification, such that a link is a list link if and only if it is a child of an <li> element in a <ul> or <ol> list with at least 2 <li> elements, all of which have <a> children whose text contents are the entire text contents of their <li> parents, except for whitespace. The motivation is that assistive-technology users need to know that a list of links is in fact a list, and visual users need all items in a list to be links if they are to understand that any non-underlined item in the list is a link. This change plus corresponding changes in validation files plus a bug correction are incorporated into version 4.6.1.