search

cvuchener / k90-linux-driver

Linux kernel space driver for Corsair Vengeance K90 Keyboard
21 stars 2 forks source link

Broken volume up key #4

Closed ceribik closed 8 years ago

ceribik commented 8 years ago

Not sure if this is the same driver as the one in linux 4.4 but if so it broke my volume up key.

It no longer reports a scancode, yet is somehow able report a keycode of 721 (using scankey).

See https://bbs.archlinux.org/viewtopic.php?pid=1604409#p1604409

cvuchener commented 8 years ago

Volume Up use the same usage code as G18 (0xe9) and I forgot to test the usage page when remapping, so I think the driver is treating it as G18. That should be an easy fix.

cvuchener commented 8 years ago

The latest commit (5f447e3) fixes this for me. Can you confirm it works before I send a patch to the LKML?

ceribik commented 8 years ago

I might be able to test in the next day or so. Will let you know.

nandryshak commented 8 years ago

@cvuchener Yes, that works. Thanks for the quick fix!

ceribik commented 8 years ago

Confirmed fixed as well. Please let us know which mainline kernel version it gets accepted into.

cvuchener commented 8 years ago

The patch has been merged in Linus' tree : https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d66435cc7da95964cb386674bd82ec12ca66320a

It should be available in the first 4.6 rc (not yet tagged).

ceribik commented 8 years ago

Has this been merged yet? I'm on 4.6.3 and I still have to recompile the module myself, otherwise the volume up/down keys don't work.

cvuchener commented 8 years ago

Yes, it has been merged (see the commit linked above). And I checked: mainline 4.6.3 contains the patched line.

I did not update my fedora recently, but it should have 4.6 now, I will test that.

cvuchener commented 8 years ago

I removed my dkms module and updated my kernel to 4.6.3 (from fedora 24), and it works for me.

ceribik commented 8 years ago

Confirmed fixed.