Closed hroncok closed 7 years ago
Amended.
Will add other Wa-Tor related homeworks here.
@MarekSuchanek Please review the NumPy part. Tests and impl. in my wator repo (private, you have access).
Reviewed and it (everything) looks great...
Only thing is that not so many numpy
features are being used. If Pandas will be about something else, I might propose to add some statistics-collector with ability to plot populations, exports and compute some interesting statistic stuff. Then it could be re-used in PyQt - some stats window at the end of simulation or on pause. Or some equilibrium-settings-finder. But maybe just thinking too much about what I would like to try with it (and hopefully I will try it soon)...
The Pandas lesson is designed to be before NumPy, so this would be a bit problematic. Although what you say definitely sounds interesting.
I think the amount of NumPy here is comparable with last year's task. You have a bunch of NumPy arrays and you have to traversate them and do some algorithms.
Yeah, it is true that the difficulty is about the same now (maze
had the paths, directions, distances, reachability and wator
has the random generation, reproduction, energies and sharks/fishes movements).
Maybe we can just show it (if there will be time to implement it) as a bonus :snake:
Or we can offer it as a bonus task to help people reach points if they need it (as a safety net and motivation to finish MI-PYT).
Good idea :thumbsup:
@MarekSuchanek Please review the Cython part. Tests and impl. in my wator repo (cython branch).
Cython reviewed:
requirements.txt
(python setup.py install
doesn't work without installed requirements beforehand) - same for the previous numpy
tasksmall typo fixed in the assignment
Thanks.
for implementation I would provide the
requirements.txt
(python setup.py install
doesn't work without installed requirements beforehand) - same for the previousnumpy
task
Right.
This is now considered finished from my POV. I'm not programming PyQt homework to tests things out just yet, we can update the homework later if we find out troubles.
@MarekSuchanek Can I merge this?
I want to get this approved before I go deeper to Cython and PyQt.