cvweiss / skillq

A web based Skill Monitor for Eve Online.
https://SkillQ.net
MIT License
19 stars 5 forks source link

Unable to remove my character #46

Closed Ionaru closed 6 years ago

Ionaru commented 6 years ago

I am unable to remove my character from SkillQ. The error is: Uncaught SyntaxError: missing ) after argument list on this line:

<td><span class='pull-right'><a href='#' onClick="verifyRemoval('Cap&#039;n Proton', 92840153); return false;">X</a></span></td>

I think the quote (') in my character's name isn't properly being escaped. image

I was able to remove the character successfully by editing the HTML and escaping the ' in my character's name so it looks like this: verifyRemoval('Cap\'n Proton', 92840153).

cvweiss commented 6 years ago

OK this hopefully addressees it, I tried to shortcut it earlier, meh

Ionaru commented 6 years ago

Looks good, verified 👍