Closed bettbra closed 3 years ago
Thanks @bettbra this is a really great PR! I made some minor notes in my review. Generally looks good to go.
Did you run flake8
on it? That's what we use in cvxpy for linting. I would like to switch to black
autoformatting, but that should be a separate PR.
I haven't fixed all the flake8 issues yet but will later this evening. Gotta take the kids to football right now, ha!
Sounds good! Actually if it's easier you're welcome to just run "black *" to get all the formatting right, since I've reviewed the content. No need to fiddle with flake8 (unless you prefer it).
I decided to merge and apply black formatting myself, just for simplicity.
A collection of mods while upgrading to CVXPY >= 1.1.13:
There's more to do to be sure, including sprucing up various docstrings. But that can wait for a separate pull request; seems more useful right now to restore the base to operation.