search

cvxgrp / qcml

A Python parser for generating Python/C/Matlab solver interfaces
Other
42 stars 9 forks source link

Put check for n > 1 AbstractDim in codegen #39

Closed chinasaur closed 10 years ago

chinasaur commented 10 years ago

Wasn't clear how to do the comparison technically correctly, although the workaround was probably fine. This is cleaner though.

I didn't test the generated code for correct results from the solver, just checked that the code generates and in case of C compiles.

echu commented 10 years ago

The generated code the fir filter example now has no elements for "G".

See line 2667: https://travis-ci.org/cvxgrp/qcml/builds/12777833.

nnzG = 0;

on that line. Must have introduced a bug somewhere else. (Does CBP still work?)

chinasaur commented 10 years ago

Okay, I think it should be fixed now; see what Travis says...

Was overzealous in refactoring; don't have the generator flow that clear in mind.

echu commented 10 years ago

that took care of it!