search

cvzi / Spotify-Genius-Lyrics-userscript

Userscript, shows lyrics from genius.com on Spotify web
https://greasyfork.org/en/scripts/377439-spotify-genius-lyrics
GNU General Public License v3.0
42 stars 4 forks source link

fix `getSongTitleAndArtist()` #25

Closed cyfung1031 closed 1 year ago

cyfung1031 commented 1 year ago

The current implementation for getSongTitleAndArtist() will get wrong results if "Now Playing View" is shown.

"Now Playing View"

Screen Shot 2023-07-22 at 17 53 56

Since I am not familiar with Spotify layout, I just do the minimum change to make it correct.

Screen Shot 2023-07-22 at 17 45 36 Screen Shot 2023-07-22 at 17 45 29

@cvzi You might further review how to avoid the wrong selection of elements.

cvzi commented 1 year ago

I don't seem to have this "Now playing" view yet.