cvzi / Youtube-Music-Genius-Lyrics-userscript

Userscript, Show lyrics/songtexts from genius.com on Youtube Music
https://greasyfork.org/en/scripts/406892-youtube-music-genius-lyrics
GNU General Public License v3.0
15 stars 1 forks source link

(Bug) Lyrics button gets hidden when music is playing #15

Closed cyfung1031 closed 1 year ago

cyfung1031 commented 1 year ago

@cvzi I believe the mechanism of the toggle the button was implemented complicated (and not good) as per my experience in changing the YouTube version.

I can just inform you so that you can find the corresponding code and fix the issue.

In YouTube Music, the lyrics button can show when the user enters the song page. it will auto show or manual show by clicking the button. then, when the user is playing the song, and move to other pages, just like clicking the home button to see other things. if the lyrics is closed, cannot reopen again.

The detection for music available shall check the playing music not whether it is music page or not.

( The current mechanism is making the sequence of operations as a whole so if any step of that breaks, everything breaks. )

https://github.com/cvzi/Youtube-Music-Genius-Lyrics-userscript/assets/44498510/be4684b3-0bb9-40f7-a340-ffd51655f2cb