search

cvzi / darkmodewallpaper

🌓 A live wallpaper for Android that respects dark theme mode 🌇
https://f-droid.org/packages/com.github.cvzi.darkmodewallpaper/
GNU General Public License v3.0
144 stars 11 forks source link

Launcher is not provided correct wallpaper colour by system when using DMLW. #115

Open RokeJulianLockhart opened 1 year ago

RokeJulianLockhart commented 1 year ago

Per https://forum.fairphone.com/t/93213?u=rokejulianlockhart,

https://github.com/8bitPit/Niagara-Issues/issues/2147#issue-1491067789 and https://github.com/8bitPit/Niagara-Issues/issues/2193#issue-1570135114

demonstrate that the cause of this issue is unknown, but is definitely experienced by users of Dark Mode Live Wallpaper (myself). The developers appear confident that it must be caused by DMLW or Android.

Please investigate.

cvzi commented 1 year ago

Is the source code of that launcher available or is it closed source?

RokeJulianLockhart commented 1 year ago

Closed source, unfortunately. I understand if that is enough to prevent you assisting in any way actionable. (I apologize; I'm so used to using open-source projects I forgot to even check.)

cvzi commented 1 year ago

No that's fine, I'll check it out. It just would have been easier to understand how they are doing things.

cvzi commented 1 year ago

When does the problem appear for you?

cvzi commented 1 year ago

I can't reproduce this, it always works for me, both with Niagara and the "default" Android 12 launcher on the emulator.

In the next release, the colors that the launcher receives are shown in the little debug information on the bottom of the main screen of the app. When this happens again you could check there if something is different than usual.

RokeJulianLockhart commented 1 year ago

@cvzi, which application version shall that new release be? Just makes it easier to verify when troubleshooting.

cvzi commented 1 year ago

It is 1.4.13. It is published now

cvzi commented 1 year ago

Now there is an option to select the colors manually in the advanced settings

harmtemolder commented 1 year ago

Wow, thanks for all your hard work @cvzi

Sometimes I still get light text on my day wallpaper, right after it switched from night to day, but turning the screen off and on again fixes that, so I'm not too bothered by that. And I now see that I have Immediately inform Android about new wallpaper colors after unlock set to WAIT, so I'll set that to IMMEDIATELY for a while, see if that solves anything.

RokeJulianLockhart commented 1 year ago

Wow, thanks for all your hard work @cvzi

Indeed.

I now see that I have Immediately inform Android about new wallpaper colors after unlock set to WAIT, so I'll set that to IMMEDIATELY for a while, see if that solves anything.

Per this, which option is enabled isn't obvious. Does the previous picture depict it active or not? Would be nice if the option were redesigned to be more explicit.