cvzi / darkmodewallpaper

🌓 A live wallpaper for Android that respects dark theme mode 🌇
https://f-droid.org/packages/com.github.cvzi.darkmodewallpaper/
GNU General Public License v3.0
171 stars 11 forks source link

Zoom effect bug #25

Closed JstormZx closed 2 years ago

JstormZx commented 3 years ago

Hi. I noticed a minor bug in the app's operation

I'll try to be as specific as possible even if the bug is minor.

Device: Xiaomi Redmi note 10 pro, Android 11, Miui 12.5.3.0 RKFMIXM.

Launcher: Nova launcher prime. 7.0.34

Imported wallpaper immediately after first launch.

Problem: I noticed the wallpapers were slightly off center, leaning towards the right side of the screen

This broke pretty much the entire app afterwards. No matter what you do. Remove the imported wallpaper and select a new one from the gallery, it was still off centered. To confirm that this is a bug, I repeated everything I did during setup:

• Imported current wallpaper at the initial prompt. • Turned off "use day time image" in night time settings. • Selected a new dark mode wallpaper from gallery. • Turned on zoom effect (the real culprit here after investigation) • Applied as home screen wallpaper.

After successfully being applied, the wallpaper was shifted slightly to the right. And the zoom effect didn't work. I am positive either nova launcher or Miui has something to do with this. But I disabled nova 7's wallpaper zoom effects to make sure it didn't conflict with dark mode live wallpaper. And it still happened.

I fixed it by clearing the app data and restarting the initial setup process. This time, selecting a wallpaper from the gallery instead and disabling zoom effect. The wallpapers look and change fine now.

Conclusion: The zoom effect feature is bugged on my device. And possibly could be on other phones as well.

Thanks and I hope I didn't write too much 🙂 This is actually my first issue on GitHub. Heck, the first comment I've ever typed on GitHub. So I have no idea how things work here.

Hope you had a splendid day.

Normal wallpaper: Screenshot_2021-07-08-13-32-01-664_com teslacoilsw launcher

App settings responsible for bug: Screenshot_2021-07-08-13-32-53-509_com github cvzi darkmodewallpaper

Bugged wallpaper: Screenshot_2021-07-08-13-32-56-929_com teslacoilsw launcher

cvzi commented 3 years ago

Thanks for the detailed explanation. Very good first issue!

cvzi commented 3 years ago

The zoom effect is currently not centered but can zoom slightly to the right. That explains why it is shifted to the right. It zoomed in and then it didn't zoom out completely. (I put your correct and wrong image over each other and tried to match the white logo in the center, you can see that the size of the logo does not match i.e. one is slightly zoomed in)

It should have zoomed out completely on home screen but it didn't. I don't know if this is a bug in the app or in Miui or Nova.

I couldn't reproduce it on a plain Android 11 with Nova, so might be Miui related. I will keep investigating 🙂

zoomedin

JstormZx commented 3 years ago

Ah thanks for that...it's could be miui's fault. I also tried nova 7 zoom effects and that's also kinda working but also slightly broken. So... anyway it's cool.

Thanks for the quick reply and compliment and I guess I'll wait for your investigation results.

Hehe Thanks for the app I'll never stop using it lol. And have a ridiculously good day. 🙃

cvzi commented 2 years ago

I think this should be fixed in the newest version. If not fixed, please re-open the issue.