cvzi / darkmodewallpaper

🌓 A live wallpaper for Android that respects dark theme mode 🌇
https://f-droid.org/packages/com.github.cvzi.darkmodewallpaper/
GNU General Public License v3.0
171 stars 11 forks source link

Cannot set separate wallpaper dark mode in Android 12 #27

Closed akuhl closed 3 years ago

akuhl commented 3 years ago

When I try to set a separate wallpaper for dark mode, a wallpaper picked with Google Photos is saved according to the toast message but neither set nor shown in preview.

version 1.1.2 on Android 12 Beta 3.1 with Google Pixel 5

cvzi commented 3 years ago

I just tried to run the app on the emulator and it does not work on Android 12. The app layout is wrong. Most of the buttons are not visible on Android 12. That should be easy to fix.

It is supposed to look like this:

akuhl commented 3 years ago

The app looks nothing like this on Android 12, the layout is fully broken: ![Uploading Screenshot_20210811-174530.png…]()

akuhl commented 3 years ago

Interestlingly, sharing a Wallpaper from Google Photos app to your app works for setting the wallpaper.

cvzi commented 3 years ago

Android 12 now requests a wide wallpaper (2*screen_height_pixels x screen_height_pixels). In earlier Android versions it requested a square wallpaper (screen_height_pixels x screen_height_pixels). Because it requested such a wide wallpaper, the preview in the app was also very wide, and consequently broke the layout. I have fixed that by restricting the preview to half the screen size.

As far as I can see on the emulator, everything else seems to work on Android 12.

(It will take at least two days before I can release it on Google Play because I rely on F-Droid to compile and build the app and that takes some time)

akuhl commented 3 years ago

Is there any new build available yet on F-Droid? AFAICS there is still build 1.1.2...

cvzi commented 3 years ago

They have not built it yet, not sure why it takes so long.

I have build it on my machine in the meantime. You can download the apk file from here if you want to test it: https://github.com/cvzi/darkmodewallpaper/releases/tag/v1.1.6 You would have to uninstall the app first because this version is signed by my own key and the older version was signed by F-droid

akuhl commented 3 years ago

Layout is fixed with 1.1.6 your user signed build