search

cvzi / genius-lyrics-userscript

A userscript library to show lyrics from genius.com on other websites
GNU General Public License v3.0
14 stars 5 forks source link

minor code change for scrollToBegining() #44

Closed cyfung1031 closed 1 year ago

cyfung1031 commented 1 year ago

the traditional scrollTo method is not reliable since offsetTop computation is complicated and usually wrong for modern complex layout structure.

use scrollIntoView instead.

However using scrollIntoView will not instantly scroll to the desired position. It is because scroll-behavior: smooth is set by default. scroll-behavior: auto shall temporarily set by CSS. (avoid using scrollIntoViewOptions)

after the scrollTop is ready, allow the main window to call scrollLyrics. This is done by setTimeout delay before that, the content will be still visible just autoscroll is not yet ready

cyfung1031 commented 1 year ago

note: all changes in iframeCSSCommon would not be taken effect if there is html text cache

cvzi commented 1 year ago

Thanks!