Romaji Lyrics Detection Not Working - Githubissues

cvzi / genius-lyrics-userscript

A userscript library to show lyrics from genius.com on other websites

GNU General Public License v3.0

13 stars 5 forks source link

Romaji Lyrics Detection Not Working #78

Closed cyfung1031 closed 6 hours ago

cyfung1031 commented 1 month ago

Screen Shot 2024-07-22 at 0 51 12

https://greasyfork.org/en/scripts/377439-spotify-genius-lyrics/discussions/251399

`hit.result.language` is removed in the latest genius ?

if (hit.result.language === 'romanization') {

`isGeniusTranslationLike` is not working since `hit.result.language` detection failure

scoring

2000

if (hit.type === 'song') {
2600
if (hit.result.updated_by_human_at) {
+400
if (isGeniusTranslationLike) {
-1000

3007

if (hit.type === 'song') {
2600
if (hit.result.updated_by_human_at) {
+400
(micro scoring - +7 )

TODO

[x] Fix the romaji detection due to the omitted field hit.result.language
[x] Fix the variable isGeniusTranslationLike due to the omitted field hit.result.language
[ ] Test and Verify with various examples
[ ] Close this issue and Greasy Fork discussion

cyfung1031 commented 1 month ago

Let me fix the issue together with the review for the recent YouTube's extension restriction.