Fix the crash:Scroll the first page to second > when the scrolling do no...

cwRichardKim / RKSwipeBetweenViewControllers

Swipe between ViewControllers like in the Spotify or Twitter app with an interactive Segmented Control in the Navigation Bar

MIT License

1.67k stars 156 forks source link

Fix the crash:Scroll the first page to second > when the scrolling do no... #18

Closed Nirvana-icy closed 9 years ago

Nirvana-icy commented 9 years ago

During Page Scrolling,we should avoild user to tap the segmentButton to fix the crash.
We find the crash situation:
Launch the demo > scrolling in the first page > and then quickly tap the fourth segment button => the app will crash
So I add isPageScrollingFlag to avoid user to tap the segment button during scrolling to fix the crash.
Thank you for RKSwipBetweenViewControllers.

cwRichardKim commented 9 years ago

This is great! I'm going to make a few changes though. In general, when you have a flag like this, you should use the complementary functions to turn it on / off. For example, if you turn the flag on in scrollViewWillBeginDragging then you should turn it off in scrollViewWillEndDragging

edit: Looks like this is a scrollView delegate issue. I think you chose the right delegate functions. Thanks for the PR!