search

cwadrupldijjit / ng2-parallax

A parallax plugin/directive for Angular 2. Learn more at:
http://cwadrupldijjit.com/ng2-parallax
MIT License
29 stars 18 forks source link

Not working in rc1 #2

Closed MurhafSousli closed 7 years ago

MurhafSousli commented 8 years ago

Hi .. is there any plans for an update, it's not working with the latest rc1, thank you

cwadrupldijjit commented 8 years ago

It's in my plans. I haven't spent a lot of time on it lately due to my busy schedule and working late in efforts of shipping my business's product.

Have you continued to work in webpack? It's likely I'll extend the functionality to webpack once I've gotten it all working with the @angular release candidate.

MurhafSousli commented 8 years ago

yea still working with webpack, that's cool, the rc2 is coming next week as I heard.

warapitiya commented 8 years ago

Not working for RC4. Hope you'll have a solution for this ASAP.

FYI: Using System.js

cwadrupldijjit commented 8 years ago

The reasons why the plugin isn't working in >= rc1 is because of the package scheme changing in rc1. I'm working on it, though having to put it on the back burner a bit because this if the week before my company ships its product.

I'm working on updating this bit by bit, though I don't anticipate it taking too much.

oktav777 commented 8 years ago

@cwadrupldijjit still no ETA? Thinking already on writing my own parallax directive ...

oktav777 commented 8 years ago

Only imports seems to be broken, the logic is ok!

I copied parallax.directive.ts to my project fixed the imports and it works.

import { Directive, ElementRef, Host, Input, Optional, OnInit } from 'angular2/core'
                                                                             ^

to

import { Directive, ElementRef, Host, Input, Optional, OnInit } from '@angular/core'
                                                                      ^

I wanted to make pull request, tried to compile, but the build process seems to be broken, too many dependencies changed since then.

cwadrupldijjit commented 8 years ago

I'll fix that today and get back with you on it.

I'm still trying to get the new NgModules to work with it. Best case, that's figured out today and modules will work. Worst case, I ignore the modules and you just install the directive.

On Fri, Aug 19, 2016, 5:59 AM Octavian Lari notifications@github.com wrote:

Only imports seems to be broken, the logic is ok!

I copied parallax.directive.ts to my project fixed the imports and it works.

import { Directive, ElementRef, Host, Input, Optional, OnInit } from 'angular2/core' ^

to

import { Directive, ElementRef, Host, Input, Optional, OnInit } from '@angular/core' ^

I wanted to make pull request, tried to compile, but the build process seems to be broken, too many dependencies changed since then.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cwadrupldijjit/ng2-parallax/issues/2#issuecomment-240999886, or mute the thread https://github.com/notifications/unsubscribe-auth/ANTfMGf-cog0qunGmg8c3KnMV1m2O1JXks5qhZqZgaJpZM4Iz8Ub .