search

cwadrupldijjit / ng2-parallax

A parallax plugin/directive for Angular 2. Learn more at:
http://cwadrupldijjit.com/ng2-parallax
MIT License
29 stars 18 forks source link

App Module works just fine with angular-cli #9

Closed kirikintha closed 5 years ago

kirikintha commented 7 years ago

Hey there, I am installing this on a new angular-cli project, and I had to use the app module to load this. It seems to be loading fine, and webpack has no issue. Just thought you should know!

import { Parallax,
         ParallaxConfig } from 'ng2-parallax/commonjs';
@NgModule({
  declarations: [
    AppComponent,
    Parallax
  ]
  ...
})
export class AppModule { }
crutchcorn commented 7 years ago

Same for me, I would suggest making a change to the README dismissing the issues with Webpack

cwadrupldijjit commented 7 years ago

It used to have issues, but I'm grateful that they have been fixed.

I'll remove that when I have a second to check it out.

cwadrupldijjit commented 5 years ago

This has been updated and fixed with the changes I made to upgrade it from the half-working state from Angular 2 beta. I'll close this issue for now, but if it still fails, feel free to open it up in the new repo: cwdj-parallax