search

cwaldbieser / txcasproxy

A CAS authenticating reverse proxy using Twisted
GNU General Public License v3.0
0 stars 7 forks source link

Docker image pull request #1

Closed dizzy closed 9 years ago

dizzy commented 9 years ago

Carl,

I have created a Dockerfile that could be used to integrate with dockerhub registry for building / pushing (already did it in my fork but would be nice to have one from original repo - that btw gets automatically build each time a change performed)

Thanks

cwaldbieser commented 9 years ago

George,

Is it customary to have the Docker file in the top level of the project, or should it be in a folder like contrib/Docker or something? I have played around with the online Docker examples, but I am still pretty new to the technology. I am not sure what the current conventions are.

I guess I will merge this PR now, and it makes sense later to move it to a folder, I can do that.

dizzy commented 9 years ago

Carl, having the Dockerfile in top level project makes easy to set up automated builds on Docker Hub (as in https://docs.docker.com/docker-hub/builds/). Basically when docker hub tries to build image it will look for a Dockerfile in the specified github repository and use it for building. You will see that in Dockerfile there's a line

ADD . /txcasproxy/

that adds all sources (.) to the Docker container in txcasproxy directory. Hope this makes sense and thanks for getting the pull request