cwalter-at / freemodbus

BSD licensed MODBUS RTU/ASCII and TCP slave
720 stars 379 forks source link

mbfuncdisc.c line 54 Is this string correct? #21

Open loki-amorf opened 3 years ago

loki-amorf commented 3 years ago

https://github.com/cwalter-at/freemodbus/blob/f16701094ca64df3a0366dde1c186a55976d61e4/modbus/functions/mbfuncdisc.c#L54 Why do we check if read coils were enabled? Why don't we check if read discrete inputs were enabled? I gues it should be something like #if MB_FUNC_READ_DISCRETE_INPUTS_ENABLED > 0

CyrilJiang commented 2 years ago

Yes,I think so.