cwc / eventsource_ex

Elixir EventSource (Server-Sent Events) client
20 stars 16 forks source link

Update httpoison dep #3

Closed davedoesdev closed 7 years ago

davedoesdev commented 7 years ago

When I compile eventsource_ex, I get the following warnings:

===> Compiling hackney
src/hackney_pool.erl:213: Warning: crypto:rand_bytes/1 is deprecated and will be removed in a future release; use crypto:strong_rand_bytes/1

src/hackney_multipart.erl:271: Warning: random:uniform/1: the 'random' module is deprecated; use the 'rand' module instead

I think the first one at least is definitely a good reason to upgrade?

cwc commented 7 years ago

Sure, I've got no problem updating deps since I can lock existing upstream projects to a given commit hash.

Thanks for putting in some time on this btw. If you squash all the warnings and get the deps updated for me, I'll push a release to Hex.

davedoesdev commented 7 years ago

Sure, I can do that. Might be a couple of days till I get round to it...

cwc commented 7 years ago

Yeah no worries. I whipped this up for a work project but made it a separate module because I figured it'd be handy in other apps/for other people, hence the lack of updates. It's working in prod so good enough for me. 😁

davedoesdev commented 7 years ago

@cwc I just grabbed a moment and did a PR.

davedoesdev commented 7 years ago

Btw thanks for this module, I'm using it here.

cwc commented 7 years ago

Awesome! Very cool to see that it's useful for someone else. 🎉 I'll try to push a release soon.

davedoesdev commented 7 years ago

Thanks

davedoesdev commented 7 years ago

Hey @cwc thanks again for this library. Is there any chance of publishing it to hex?

cwc commented 7 years ago

v0.0.1 has been published to Hex. :)

davedoesdev commented 7 years ago

@cwc thanks

davedoesdev commented 7 years ago

By the way, I get this warning when compiling:

==> eventsource_ex
warning: the dependency :eventsource_ex requires Elixir "~> 1.3.4" but you are running on v1.4.5
Compiling 2 files (.ex)
Generated eventsource_ex app

Do you know why I get that warning but I don't when I compile httpoison which has elixir: "~> 1.2" in its mix.exs file?

davedoesdev commented 7 years ago

Is ~> saying only the final number in the version can change?

davedoesdev commented 7 years ago

https://hexdocs.pm/elixir/Version.html @cwc was your intent only to support Elixir 1.3?

cwc commented 7 years ago

I intended to declare the required version as the lowest on which I've confirmed that the library now works, which is 1.3.x due to the use of its DateTime module. 1.4 and beyond will likely continue to work fine as I doubt they'll make breaking changes.

I'll set the required version to ~> 1.3 for the next version I push, which shouldn't show a warning for any 1.x after 1.3.

davedoesdev commented 7 years ago

@cwc thanks!

davedoesdev commented 7 years ago

Hi @cwc is it okay to push another version with that change please?

cwc commented 7 years ago

Sure, I can try to do that soon. Before I do, have you come across any other changes you'd like to see? I haven't needed to do any development on the lib myself, as it's holding up very well in production as-is.

davedoesdev commented 7 years ago

Nope, seems very solid - nice work

cwc commented 6 years ago

v0.0.2 has been published. I've verified that there are no warnings for Elixir 1.5.

davedoesdev commented 6 years ago

Confirmed - thanks again