search

cweagans / composer-patches

Simple patches plugin for Composer
https://www.cweagans.net/project/composer-patches
BSD 3-Clause "New" or "Revised" License
1.49k stars 239 forks source link

Should "composer status" fail after successful patch? #573

Open azalea666 opened 2 months ago

azalea666 commented 2 months ago

Verification

Which file do you have feedback about? (leave blank if not applicable)

No response

Feedback

i don't know if it's a bug or not, or misconfiguration, but after successfully applying two patches with the plugin, composer status reports "You have changes in the following dependencies: ... [lists packages changed by patch (or files if using -v)] ... Composer [status] failed, composer command failed: exit status 1. stderr="

is this the expected behavior?

cweagans commented 2 months ago

Presently, yes, that's expected. I'd be open to a PR that makes composer status report things in a patch-aware way!

azalea666 commented 2 months ago

i think that would be cool. i ran into a similar problem with a plugin that does security hardening, removing documentation and test files and such, which makes "composer status" fail for the same reason

thanx