search

cweagans / docker-bg-sync

A container that syncs files between two configurable directories.
225 stars 39 forks source link

Default SYNC_PREFER=newer #14

Open leymannx opened 6 years ago

leymannx commented 6 years ago

It seems confusing for some folks (and me) that after the initial sync the ongoing sync is only unidirectional (container to host only). Let's make it bidirectional by default. Refs #2

leymannx commented 6 years ago

Interestingly EugenMayer's docker-sync has decided to prefer the host: https://github.com/EugenMayer/docker-sync/issues/108

cweagans commented 6 years ago

I clarified this in the other issue, but just to restate it here: the sync is not unidirectional by default. Unison syncs in both directions, and if it's not, something else is wrong. Also, the current default is to prefer $SYNC_SOURCE for conflict resolutions, which should be the host FS (as in eugenmayer's docker-sync).

leymannx commented 6 years ago

@cweagans I guess this makes this PR unnecessary then. The problem then must be something else I guess.

cweagans commented 6 years ago

I think newer is more sane default, actually. I just need to do some testing and try to break it.