Allow container to be run as arbitrary user, other general maintenance

cweagans / docker-bg-sync

A container that syncs files between two configurable directories.

224 stars 39 forks source link

Allow container to be run as arbitrary user, other general maintenance #25

Closed rfay closed 5 years ago

rfay commented 5 years ago

It didn't work out of the box when running the container as a non-root user. This PR attempts to fix that.
Update unison version
Update Alpine version
Logs go to stdout
Added a healthcheck
Started with an initial SYNC_MAX_INOTIFY_WATCHES so it wouldn't fail out of the box.

lmakarov commented 5 years ago

Using unison -numericids is an interesting approach. Have you run into any issue with it so far?

I noticed a few files included in the PR, which are not referenced Dockerfile:

files/etc/group
files/etc/passwd
- files/etc/sudoers.d/bgsync

rfay commented 5 years ago

I ended up having to fork docker-bg-sync and customize it quite a lot, so this PR probably isn't worth continuing with. The ability to run with the actual docker user is critical (the documented technique doesn't work if you're running with a limited user). But I don't think the work here is adequate to continue with.