search

cwebber / magit-review

Tool for code reviewing in emacs' magit. Like magit-wazzup, but more powerful.
GNU General Public License v3.0
20 stars 2 forks source link

magit-review does not work with magit HEAD #1

Open dholm opened 10 years ago

dholm commented 10 years ago

I have installed magit using el-get and I am currently using revision 6369383 on GNU/Emacs 24.3.1. When running magit-review from the Magit status buffer I receive the following traceback:

Debugger entered--Lisp error: (void-function magit-buffer-switch)
  magit-buffer-switch("*magit-review*")                                                                                                                     
  magit-review()
  call-interactively(magit-review)
  (if helm-M-x-always-save-history nil (call-interactively sym-com))
  (let* ((history (progn (let* ((--cl-var-- extended-command-history) (i nil) (--cl-var-- nil)) (while (consp --cl-var--) (setq i (car --cl-var--)) (if (commandp ...) (progn ...)) (setq --cl-var-- (cdr --cl-var--))) (nreverse --cl-var--)))) command sym-com in-help help-cand (he$
  helm-M-x()
  call-interactively(helm-M-x nil nil)
cwebber commented 10 years ago

Ah... I have not been using magit-review much lately, though I may return to it again when I get deeper into code review mode.

In the meanwhile, you might find that the branch viewer now has a -n flag to show only branches not merged to head, and it's a lot faster than magit-wazzup. (It still doesn't do the categorical sorting that magit-review does though.)

cwebber commented 10 years ago

Hopefully we can get this fixed! That was just a recommendation in the meanwhile if you're frustrated with magit-wazzup :)