cweijan / vscode-database-client

Database Client For Visual Studio Code
https://database-client.com
MIT License
2.39k stars 264 forks source link

[FEATURE REQUEST] Parameter behaviour #1183

Closed LeonISKopp closed 1 week ago

LeonISKopp commented 2 weeks ago

I really like this extension, but unfortunately i can't really make a use of it because there are really no options to define sql parameter behaviour.

For example at my work, we have many many sqls that have parameter that starts with "@" or "$". It would be great if there is an option to change the indicator of a parameter instead of only ":".

Another thing is, maybe i'm just stupid, you can't really use the parameter in a "in" clause. For example "WHERE visitNr IN (:param)". The behaviour of the parameter is kind of weird, because i can only type one value. If for example i want to type two values, which is intended for the "IN" clause, it would be great if it would work when i do it like this 567, 432 (Two values seperated by a comma). Right now, if i type two values seperated by a comma, it will behave like one value. Also the same with strings 'test1', 'test2'. Please correct me if there is a way to parse two values for one parameter.

haiku-p commented 2 weeks ago

totally agree :D I have this issue for a very long time, thanks for pointing out

cweijan commented 1 week ago

Hi, I added the variableIndicator setting in version 7.5.0, you can use it to configure the variable indicator.

{
    "database-client.variableIndicator": [
        ":",
        "$"
    ]
}
LeonISKopp commented 1 week ago

Thank you very much for adding this feature. It works like a charm!

haiku-p commented 1 week ago

Thank you for the quick response, it is really nice of you

On Wed, Jun 19, 2024 at 09:02 LeonISKopp @.***> wrote:

Thank you very much for adding this feature. It works like a charm!

— Reply to this email directly, view it on GitHub https://github.com/cweijan/vscode-database-client/issues/1183#issuecomment-2177901678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPAVXXG7KE2HMW7M6JXKCLZIEUKFAVCNFSM6AAAAABJH3WLW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXHEYDCNRXHA . You are receiving this because you commented.Message ID: @.***>