search

cweill / gotests

Automatically generate Go test boilerplate from your source code.
Apache License 2.0
4.92k stars 346 forks source link

fix: render template load reset #151

Closed butuzov closed 3 years ago

butuzov commented 3 years ago

This fixes reset for render's template load, bug appears only while running tests, when previous one is changing text one (if none of the template* params provided).

Adds tests for output.Option checkers

Also fixes two tests: 1) Undefined Interface - solution fixed golden 2) Entire Directory - solution provide template name (testify).

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.04%) to 95.566% when pulling 58e10f3688c45d427199f246aca3ac33675acd3d on butuzov:fix/render.tmpls into 44f58edceb05eca43aafd35a8fcd23f23415d162 on cweill:develop.

butuzov commented 3 years ago

It's weird that example 037 is passing, but honestly I have no idea without -v (which is gonna be added in #150 )

cweill commented 3 years ago

@butuzov You'll want to update the branch now.

butuzov commented 3 years ago

@cweill Did you have a chance to check my response? The test was added before the bug was introduced, even with this small fix, code has a race condition, I will fix if/when find.

cweill commented 3 years ago

@butuzov Thanks, sorry I missed it. Can you please file an issue to track this bug. Then you can Squash and Merge.

butuzov commented 3 years ago

@butuzov Thanks, sorry I missed it. Can you please file an issue to track this bug. Then you can Squash and Merge.

I believe only collaborators can squash and merge. All I see is Close with Comment and Comment. Maybe it also worth checking if squashing enabled in settings (the main repo settings page, down the page).

PS Issue Filed.

butuzov commented 3 years ago

Thanks. I will check what I can do with parallelization as it really affects tests atm. Cheers.